Discussion:
[PATCH] netfilter: ebtables: clean up initialization of buf
(too old to reply)
Colin King
2017-10-16 10:24:02 UTC
Permalink
From: Colin Ian King <***@canonical.com>

buf is initialized to buf_start and then set on the next statement
to buf_start + offsets[i]. Clean this up to just initialize buf
to buf_start + offsets[i] to clean up the clang build warning:
"Value stored to 'buf' during its initialization is never read"

Signed-off-by: Colin Ian King <***@canonical.com>
---
net/bridge/netfilter/ebtables.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index 3b3dcf719e07..37817d25b63d 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -2112,9 +2112,8 @@ static int size_entry_mwt(struct ebt_entry *entry, const unsigned char *base,
for (i = 0, j = 1 ; j < 4 ; j++, i++) {
struct compat_ebt_entry_mwt *match32;
unsigned int size;
- char *buf = buf_start;
+ char *buf = buf_start + offsets[i];

- buf = buf_start + offsets[i];
if (offsets[i] > offsets[j])
return -EINVAL;
--
2.14.1
Pablo Neira Ayuso
2017-11-06 13:50:02 UTC
Permalink
Post by Colin King
buf is initialized to buf_start and then set on the next statement
to buf_start + offsets[i]. Clean this up to just initialize buf
"Value stored to 'buf' during its initialization is never read"
Applied, thanks.

Continue reading on narkive:
Loading...