Discussion:
[PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h
(too old to reply)
Andrew Lunn
2017-11-02 12:53:05 UTC
Permalink
Please drop the Why.
The lan9303 driver defines eth_stp_addr as a synonym to
eth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00.
eth_reserved_addr_base is also used to define the start of Bridge Reserved
ethernet address range, which happen to be the STP address.
br_dev_setup refer to eth_reserved_addr_base as a definition of STP
address.
- Move the eth_stp_addr definition to linux/etherdevice.h
- Use eth_stp_addr instead of eth_reserved_addr_base in br_dev_setup.
I was thinking along the same lines when reviewing your lan9303 patch.

Reviewed-by: Andrew Lunn <***@lunn.ch>

Andrew
David Miller
2017-11-03 05:18:39 UTC
Permalink
From: Egil Hjelmeland <***@egil-hjelmeland.no>
Date: Thu, 2 Nov 2017 10:36:48 +0100
The lan9303 driver defines eth_stp_addr as a synonym to
eth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00.
eth_reserved_addr_base is also used to define the start of Bridge Reserved
ethernet address range, which happen to be the STP address.
br_dev_setup refer to eth_reserved_addr_base as a definition of STP
address.
- Move the eth_stp_addr definition to linux/etherdevice.h
- Use eth_stp_addr instead of eth_reserved_addr_base in br_dev_setup.
Applied, thank you.

Continue reading on narkive:
Loading...